Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed Issue with Acceptances Being Created #15245

Merged
merged 1 commit into from
Aug 8, 2024

Conversation

spencerrlongg
Copy link
Collaborator

Description

Acceptances were being created for acceptable assets being checked out to Locations or other Assets - leading to some reports of users declining acceptance of things that were not assigned to them, but to a Location or an Asset. This just adds a simple conditional to prevent that for now.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

Copy link

what-the-diff bot commented Aug 7, 2024

PR Summary

  • Restructured conditions in CheckoutableListener.php
    This update brings a modification to the CheckoutableListener.php file where a condition to verify the type of $event->checkedOutTo has been added. This means the system now checks if the checked-out item is related to a user. If it's not, it stops further calculations and returns a null value, hence increasing overall system efficiency.
  • Repositioned Item Acceptance Requirement Check
    The check to determine if a checked-out item requires acceptance ($event->checkoutable->requireAcceptance()) has been moved. This change enhances the system's logical order and might improve our application's performance.

@snipe snipe merged commit 8094f3c into snipe:develop Aug 8, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants